Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added social media profile urls in feedback page. #1366

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

vishanurag
Copy link
Contributor

Title and Issue number

Title : Added social media profile urls in feedback page

Issue No. : #1364

Code Stack : HTML

Close #1364

Description

  • Added social media profile urls in feedback page.
  • Now, the social media profiles will open when clicked on these icons.

Video/Screenshots (mandatory)

Untitled.video.-.Made.with.Clipchamp.10.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

@apu52 please review & merge my pull-request under GSSoC'24

Are you contributing under any Open-source programme?

Yes, GSSoC'24

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit dbba6fe
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66b63c4b79b4830008fff600
😎 Deploy Preview https://deploy-preview-1366--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishanurag
Copy link
Contributor Author

There is some issue with the video recorder...

@vishanurag
Copy link
Contributor Author

There is some issue with the video recorder...

Recording.2024-08-10.143902.mp4

@apu52 @itsekta
This is the output...

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishanurag good work

@apu52 apu52 merged commit 599aa9a into apu52:main Aug 10, 2024
6 checks passed
@apu52 apu52 added bug Something isn't working gssoc labels Aug 10, 2024
@vishanurag
Copy link
Contributor Author

vishanurag commented Aug 10, 2024

@apu52 can you please add level2 label on this pr 🙏

@vishanurag
Copy link
Contributor Author

Because without level label I will not be able to get the points of this pr in GSSOC'24. Hope you understand 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The social media links are not working on feedback page.
2 participants