Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[execution-pool] BlockRetrievalRequest struct -> enum #15812

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hariria
Copy link
Contributor

@hariria hariria commented Jan 25, 2025

Description

Deprecates the BlockRetrievalRequest struct in favor of a BlockRetrievalRequest enum. This is needed as execution pool plans to make BlockRetrievalRequests that include epoch and round information instead of target_block_id.

The plan is to phase this in two releases. The first release will introduce the new BlockRetrievalRequest enum and all corresponding structs / logic that use it. The second release will deprecate the BlockRetrievalRequestV1 struct and all related structs / logic.

Important

Some TODOs around deprecation are already marked in the code. Additional TODO in future PRs:

  • process_block_retrieval param should change to IncomingBlockRetrievalRequestV2
  • spawn_block_retrieval_task channel should change to IncomingBlockRetrievalRequestV2

Additional Questions

  • Why does consensus.yaml require TUPLEARRAY instead of TUPLE?

How Has This Been Tested?

@hariria hariria requested a review from bchocho January 25, 2025 03:59
Copy link

trunk-io bot commented Jan 25, 2025

⏱️ 20m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 8m 🟩🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 42s 🟩🟩🟩🟩
permission-check 7s 🟩🟩🟩🟩
permission-check 7s 🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@hariria hariria self-assigned this Jan 25, 2025
@hariria hariria force-pushed the andrew/exec-pool-block-retrieval-request branch 2 times, most recently from d98225a to be5e4c3 Compare January 25, 2025 04:19
@hariria hariria force-pushed the andrew/exec-pool-block-retrieval-request branch from be5e4c3 to 2c36388 Compare January 25, 2025 20:13
@hariria hariria marked this pull request as ready for review January 25, 2025 20:23
@hariria hariria changed the title [execution-pool] BlockRetrievalRequest deprecation [execution-pool] BlockRetrievalRequest struct -> enum Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant