[execution-pool] BlockRetrievalRequest struct -> enum #15812
+214
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the
BlockRetrievalRequest
struct in favor of aBlockRetrievalRequest
enum. This is needed as execution pool plans to makeBlockRetrievalRequest
s that include epoch and round information instead oftarget_block_id
.The plan is to phase this in two releases. The first release will introduce the new
BlockRetrievalRequest
enum and all corresponding structs / logic that use it. The second release will deprecate theBlockRetrievalRequestV1
struct and all related structs / logic.Important
Some TODOs around deprecation are already marked in the code. Additional TODO in future PRs:
process_block_retrieval
param should change toIncomingBlockRetrievalRequestV2
spawn_block_retrieval_task
channel should change toIncomingBlockRetrievalRequestV2
Additional Questions
consensus.yaml
requireTUPLEARRAY
instead ofTUPLE
?How Has This Been Tested?