Feature: Support Reading Filter Expressions from a File

[schoenherrg]

Fixes #1409

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

As mentioned in the Issue, we have filter expressions that exceed the command line length limit and thus need to be read from a file/stdin. This PR extends the Aptly command-line interface to be able to read filter expressions from a file using the @/path/to/file syntax or @- for stdin.

Our use case is only for the -filter argument for mirror create/mirror edit. However, there are other places in Aptly where filter expressions are accepted, so I added support for the @file syntax everywhere for consistency.

Commands where the @file syntax is supported now:

• mirror create
• mirror edit
• package search
• package show
• repo move
• repo remove
• snapshot filter
• snapshot pull
• snapshot search

Checklist

• unit-test added (if change is algorithm)
• functional test added/updated (if change is functional)
• man page updated (if applicable)
• bash completion updated (if applicable)
• documentation updated
• author name in AUTHORS

[neolynx]

excellent feature 👍

[neolynx]

would this also fix #157 ?

[neolynx]

we should increase the coverage a bit...

codecov/patch Failing after 1s — 60.49% of diff hit (target 75.09%)

[neolynx]

@5hir0kur0 please push the branch to the main aptly-dev/aptly git, then the coverage runs automatically. otherwise I need to do a separate coverage pr.. :) could you open the PR there ?

[neolynx]

the coverage test does not seem to cover all of the code, when it is invoked by the flag parsing.
I also tryed adding a test with a non existint @file, but was unable to get coverage output, as the program is aborted on error.

let's accept low coverage here...

[schoenherrg]

@neolynx Thanks for your work!

@5hir0kur0 please push the branch to the main aptly-dev/aptly git, then the coverage runs automatically. otherwise I need to do a separate coverage pr.. :) could you open the PR there?

Sorry, I didn't check my GitHub over the weekend, but I'll do it like that next time I make a PR!