Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/distribution allow slash #1269

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix/distribution allow slash #1269

merged 2 commits into from
Apr 11, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 11, 2024

Fixes #115

Sperrseeods #1089

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Add tests for publishing a mirror with slash (/) in the distribution: buster/updates

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

…-' while guessing. #110"

This reverts commit 1daa076.

Signed-off-by: Ariel D'Alessandro <[email protected]>
@neolynx neolynx requested review from mfolusiak, szakalboss and a team April 11, 2024 15:53
@neolynx neolynx mentioned this pull request Apr 11, 2024
6 tasks
@neolynx neolynx force-pushed the fix/distribution-allow-slash branch from af89cdf to ff83a48 Compare April 11, 2024 15:58
@neolynx neolynx self-assigned this Apr 11, 2024
@neolynx neolynx force-pushed the fix/distribution-allow-slash branch from ff83a48 to cb3d616 Compare April 11, 2024 16:12
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (32595e7) to head (cb3d616).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
- Coverage   74.70%   74.70%   -0.01%     
==========================================
  Files         144      144              
  Lines       16221    16216       -5     
==========================================
- Hits        12118    12114       -4     
+ Misses       3159     3158       -1     
  Partials      944      944              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx merged commit 2a2e35c into master Apr 11, 2024
5 checks passed
@neolynx neolynx deleted the fix/distribution-allow-slash branch April 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for '/' in distribution names
3 participants