Feat arg project init #868
Conversation
byawitz
changed the base branch from
master
to
feat-multiple-accounts-and-instances
| } | ||
|
|
||
| } else { | ||
| answers = await inquirer.prompt(questionsInitProject) |
There was a problem hiding this comment.
Hmm. What if we did different approach?
We start with empty "answers" object.. We try to fill ith with params from CMD, only using what is provided. We then take questionsInitProject and filter out questions that we already have answer for. Then, we show remaining questions and fill them into our answers object. If all answers were already given with params, there is no need to ask questions all-together
feat: Added list search
refactor: Improve command line to use `rawArgs`
christyjacob4
temporarily deployed
to
cli-testing
GitHub Actions
Inactive
Feat collection push improvements
…feat-general-improvements
christyjacob4
temporarily deployed
to
cli-testing
GitHub Actions
Inactive
templates/cli/lib/utils.js.twig
Outdated
| if (open) { | ||
| const start = (process.platform == 'darwin' ? 'open' : process.platform == 'win32' ? 'start' : 'xdg-open'); | ||
| cp.exec(`${start} ${url}`); | ||
|
|
||
| cp.exec(`${start} ${url}`, (err, stdout, stderr) => { | ||
| if (err !== null) { | ||
| console.log('\n'); | ||
| error('Opening in default browser. ' + err) | ||
| } | ||
| }); |
There was a problem hiding this comment.
Do we need this --open option? I think it might cause more problems than we are trying to solve. Does xdg-open work on all linux distros?
I think we can save this trouble altogether by removing the open param. We can just display the link with the --console flag and people can just click it.
Feat function init improvments
christyjacob4
temporarily deployed
to
cli-testing
GitHub Actions
Inactive
christyjacob4
merged commit fcb2ddc
into
feat-multiple-accounts-and-instances
What does this PR do?
Allowing project creation using a single command
Test Plan