Fix: Broken region flags #1616
Merged
Fix: Broken region flags #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with broken flags request in some cases.
The issue is that the
sdk.forProjectwill use whatever the last project was opened to load the Avatars API. If the project was invalid or deleted and then you'd navigate to creating a new project, it would throw an exception that the Project ID is not valid or the Project doesn't exist, hence failing the image loads.As a solution, we use
sdk.forConsoleas it'll always load the flags.Test Plan
Manual.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.