Partial TypeScript conversion #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
feat/glint-typescript-support
branch
from
6e3b0aa to
3e73a53
Compare
Windvis
force-pushed
the
chore/ts-conversion
branch
2 times, most recently
from
0b63488 to
a34360c
Compare
Windvis
added
the
internal
Windvis
force-pushed
the
chore/ts-conversion
branch
from
a34360c to
21ac883
Compare
…files This has some benefits (at the cost of slightly worse performance): - more readable - easy to add state, without refactoring to a Glimmer component - it sidesteps one of the "reference comment" bugs in Glint / TS
This adds types to the helper and converts it to a regular function since we dropped Ember <4.12 support.
v4 has official TS support, but some of our dependencies still use v3. This adds temporary types to make Glint happy. We can remove them once all our dependencies support v4, or by removing the usage in our own code.
Windvis
force-pushed
the
chore/ts-conversion
branch
from
21ac883 to
6511ee8
Compare
Windvis
force-pushed
the
chore/ts-conversion
branch
from
6511ee8 to
6eee009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial conversion to .gts / .ts. Converting everything at once is time consuming, and splitting it up also means we won't have merge conflicts in the future.
#425