Set up Glint and TypeScript for development #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
force-pushed
the
feat/glint-typescript-support
branch
from
64267c0 to
618d074
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This switches our blueprint to the TS version by editing the config and running `npx ember-cli-upgrade init` and resolving the conflicts. This should provide a good starting point for the Glint setup.
This enables Glint and adds ignore comments where needed. We can then start converting files to .gts one by one to enable type checking.
Windvis
force-pushed
the
feat/glint-typescript-support
branch
from
dc01bf5 to
6e3b0aa
Compare
Windvis
changed the title
This will be used to map components to their loose mode equivalent so Glint can typecheck loose mode templates. https://typed-ember.gitbook.io/glint/environments/ember/using-addons#using-glint-enabled-addons
Windvis
force-pushed
the
feat/glint-typescript-support
branch
from
6e3b0aa to
3e73a53
Compare
Windvis
commented
Feb 1, 2024
| @@ -28,6 +44,9 @@ | |||
| "lint:hbs:fix": "ember-template-lint . --fix", | |||
| "lint:js": "eslint . --cache", | |||
| "lint:js:fix": "eslint . --fix", | |||
| "lint:types": "glint", | |||
| "prepack": "glint -d", | |||
There was a problem hiding this comment.
This means we technically will already be publishing types once we add a .ts or .gts file, but I don't think that's a huge issue unless we document how to use them in apps. We consider these private until the docs are updated.
This makes testing the types easier and adventurous consumers can start using them (with the knowledge that things might break between releases).
Windvis
commented
Feb 1, 2024
There was a problem hiding this comment.
We can probably delete this file since it's not used, but it's part of the blueprint, and maybe Glint will support separate files in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Glint and TypeScript (.gts and .ts) support to the addon, so we can start converting all the code. When everything is converted we can then publish the types.