This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Test ability to remove duplicate test results #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Emit along with a note about what needs to be changed to support it
| page: 'Default', | ||
| vg: true, | ||
| config: { | ||
| removeDuplicateTestsPerBatch: true, |
There was a problem hiding this comment.
It should not go to the configuration.
There was a problem hiding this comment.
@kyrylodolynskyi and I talked about this offline. Keeping it in config for now is OK. In the future we might want to introduce a runner option to tests.
… the classic runner (and update overrides for non-JS langauges)
kyrylodolynskyi
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: https://github.com/applitools/eyes.sdk.javascript1/pull/1348