Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

add stitch overlap tests #173

Open
wants to merge 2 commits into
base: universal-sdk
Choose a base branch
from
Open

Conversation

IdosApplitools
Copy link
Collaborator

Added tests for overlap (formerly known as stitchOverlap)

Copy link
Collaborator

@kyrylodolynskyi kyrylodolynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don’t need to create separate tests for android and web, also vg/ufg test makes no sense since the grid doesn't even handle overlaps. Regarding the naming, I would rather call it should handle stitch overlap, because it is not going to send overlap anywhere

@IdosApplitools
Copy link
Collaborator Author

You don’t need to create separate tests for android and web, also vg/ufg test makes no sense since the grid doesn't even handle overlaps. Regarding the naming, I would rather call it should handle stitch overlap, because it is not going to send overlap anywhere

Thank you for your insights Kyrylo! I have adjusted the test accordingly.
Please let me know if you think there should be any additional changes.

Comment on lines +1494 to +1496
variants: {
'': {vg: false},
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add it. It is false by default and we don't have other variants

Suggested change
variants: {
'': {vg: false},
},

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants