Implements user invite #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaipradeesh J <[email protected]>
kaustavdm
previously requested changes
Sep 2, 2017
|
Also, you need to:
|
kaustavdm
previously requested changes
Sep 2, 2017
server/api/v1/users.js
Outdated
| /** | ||
| * Verifies invite token | ||
| */ | ||
| router.post('/invite/verify', requiredFields(['invite_token', 'email']), (req, res, next) => { |
There was a problem hiding this comment.
Make this GET, not creating anything new here
server/api/v1/users.js
Outdated
| * Generates invite token | ||
| */ | ||
| router.post('/invite', requiredFields(['user_id', 'email']), (req, res, next) => { | ||
| return jwt.createInviteJWT(req.required.user_id, req.required.email, req.app.get('jwtsecret')) |
There was a problem hiding this comment.
You are returning a promise. You need to write send out response instead. See comment
kaustavdm
reviewed
Sep 2, 2017
server/api/v1/users.js
Outdated
| /** | ||
| * Generates invite token | ||
| */ | ||
| router.post('/invite', requiredFields(['user_id', 'email']), (req, res, next) => { |
There was a problem hiding this comment.
Make user_id camelCase userID for uniformity.
Signed-off-by: Jaipradeesh J <[email protected]>
|
Thanks @dolftax. Take a potato. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After token verification, trigger user creation has to be done from front-end after user fills in username and password.
Say if user b wants to invite user a. user b generates a token for user a with email [email protected] and sends it along. user a makes a call with email [email protected] and a invite token and gets his own email in response. Then show a page for user to set username and password and .. ..