Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: docs for the new fields from AccessibilityNodeInfo #862

Merged
merged 5 commits into from
Feb 10, 2025
Merged

chore: docs for the new fields from AccessibilityNodeInfo #862

merged 5 commits into from
Feb 10, 2025

Conversation

ankahanets
Copy link
Contributor

@ankahanets ankahanets changed the title Update docs for the new fields from AccessibilityNodeInfo docs: docs for the new fields from AccessibilityNodeInfo Jan 30, 2025
mykola-mokhnach
mykola-mokhnach reviewed Jan 30, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mykola-mokhnach
Copy link
Contributor

Please also update package.json with the minimum server version supporting mentioned attributes

@ankahanets
Add minimum API level needed for the new properties
3885664 
Update package.json with the minimum server version supporting new properties
@ankahanets
Copy link
Contributor Author

Please also update package.json with the minimum server version supporting mentioned attributes

I've set "appium-uiautomator2-server": "^7.2.0" in package.json, is it correct?

@mykola-mokhnach
Copy link
Contributor

Please also update package.json with the minimum server version supporting mentioned attributes

I've set "appium-uiautomator2-server": "^7.2.0" in package.json, is it correct?

yes, thanks

@mykola-mokhnach mykola-mokhnach changed the title docs: docs for the new fields from AccessibilityNodeInfo chore: docs for the new fields from AccessibilityNodeInfo Jan 31, 2025
@mykola-mokhnach
Copy link
Contributor

@ankahanets would you have some time this week to finish the PR?

@ankahanets
Copy link
Contributor Author

@mykola-mokhnach Hi, I'm here. What I need to finish? Fix merge conflict or something else?

@mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach Hi, I'm here. What I need to finish? Fix merge conflict or something else?

Yes, merge conflicts plus tune some attribute descriptions (e.g. under which circumstances they are nulls/not present in the page source)

@ankahanets
Copy link
Contributor Author

ankahanets commented Feb 10, 2025 •
edited
Loading

@mykola-mokhnach added "Available only for text input fields" for input-type, multiline and max-text-length, and added "Available only if includeA11yActionsInPageSource setting is turned on" for the actions.

Also added "Available only if includeExtrasInPageSource setting is turned on" for extras for consistency.

All other fields absent only for unsuitable API levels, which are already mentioned.

@mykola-mokhnach mykola-mokhnach merged commit 815c247 into appium:master Feb 10, 2025
9 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
@semantic-release-bot
chore(release): 4.0.1 [skip ci]
695142c 
## [4.0.1](v4.0.0...v4.0.1) (2025-02-10)

### Miscellaneous Chores

* docs for the new fields from AccessibilityNodeInfo ([#862](#862)) ([815c247](815c247))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankahanets @mykola-mokhnach