-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LSP functionality to Rover #2272
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1ff3429
ROVER-245 Fix up Cargo.tomls and deny.toml
jonathanrainer c9ffa4a
ROVER-245 Removing deprecated PanicInfo and other fixes
jonathanrainer 9d26d4b
ROVER-245 Integrate existing LSP code
jonathanrainer 0f702b4
ROVER-245 Fix clippies
jonathanrainer 46ec41d
ROVER-245 Add code to handle adding/removing subgraphs
jonathanrainer 9411b63
ROVER-245 Upgrade to language-server 0.3.4
jonathanrainer 1bfa58b
ROVER-245 Add new InMemory OutputTarget
jonathanrainer 764b79b
ROVER-245 Rebasing after Christmas break
jonathanrainer bab2394
ROVER-245 Add polling_interval option
jonathanrainer 15a3c47
ROVER-245 Remove TODOs and fix up
jonathanrainer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
use anyhow::Error; | ||
use camino::{FromPathBufError, Utf8PathBuf}; | ||
|
||
use crate::composition::pipeline::CompositionPipelineError; | ||
use crate::composition::supergraph::config::resolver::ResolveSupergraphConfigError; | ||
use crate::composition::supergraph::install::InstallSupergraphError; | ||
use crate::composition::CompositionError; | ||
|
||
#[derive(thiserror::Error, Debug)] | ||
pub enum StartCompositionError { | ||
#[error("Could not convert Supergraph path to URL")] | ||
SupergraphYamlUrlConversionFailed(Utf8PathBuf), | ||
#[error("Could not create HTTP service")] | ||
HttpServiceCreationFailed(#[from] Error), | ||
#[error("Could not initialise the composition pipeline")] | ||
InitialisingCompositionPipelineFailed(#[from] CompositionPipelineError), | ||
#[error("Could not run initial composition")] | ||
InitialCompositionFailed(#[from] CompositionError), | ||
#[error("Could not install supergraph plugin")] | ||
InstallSupergraphPluginFailed(#[from] InstallSupergraphError), | ||
#[error("Could not resolve Supergraph Config")] | ||
ResolvingSupergraphConfigFailed(#[from] ResolveSupergraphConfigError), | ||
#[error("Could not establish temporary directory")] | ||
TemporaryDirectoryCouldNotBeEstablished(#[from] FromPathBufError), | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the latest version? I want to say I saw a bump recently; might be worth a follow-up with it, if there was one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3.5