Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSRF plugin #1006

Merged
merged 20 commits into from
May 13, 2022
Merged

feat: CSRF plugin #1006

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
482d1a7
wip
o0Ignition0o May 10, 2022
331a5e1
wip: address review issues + add a bit of documentation.
o0Ignition0o May 11, 2022
a76847c
compliance
o0Ignition0o May 11, 2022
ff83523
remove noise from the custom-headers.router.yml file
o0Ignition0o May 11, 2022
5f75844
recommended -> required + get closer to the fetch specification when …
o0Ignition0o May 11, 2022
579eac0
wip, add a bunch of comments
o0Ignition0o May 11, 2022
00cf251
more comments
o0Ignition0o May 11, 2022
00769c2
update documentation
o0Ignition0o May 11, 2022
03ca032
csrf tests: add helper functions for accepted/rejected requests
SimonSapin May 12, 2022
d4afa38
csrf: add a test for MIME type parsing
SimonSapin May 12, 2022
19f96a2
wip, try to update docs
o0Ignition0o May 12, 2022
1759abb
rename csrf disabled option to unsafe_disabled + docs pass 1/n
o0Ignition0o May 12, 2022
669b786
cors documentation part 2/n
o0Ignition0o May 12, 2022
c4f101f
update documentation snapshot
o0Ignition0o May 13, 2022
ba41af3
revert cors documentation, as we will polish it in a followup pr
o0Ignition0o May 13, 2022
95c3526
Merge branch 'main' into igni/csrf
o0Ignition0o May 13, 2022
6622d4c
Add three changelog entries:
o0Ignition0o May 13, 2022
4d27490
order breaking section items by impact
o0Ignition0o May 13, 2022
a20105b
hook the csrf plugin + send preflighted requests in our integration t…
o0Ignition0o May 13, 2022
b35ed95
revert CONTRIBUTING.md as it will be followed up on by @SimonSapin
o0Ignition0o May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,17 @@ and [Apollo's Docs Theme for Gatsby](https://github.com/apollographql/gatsby-the
.

To contribute to these docs, you can add or edit the markdown & MDX files in the `docs/source` directory.
<!--
TODO: port @everlastingbugstopper s work on rover https://github.com/apollographql/rover/pull/1118
and update this file

To build and run the documentation site locally, you'll have to install the relevant packages by doing the following
from the root of the `router` repository:

```sh
cd docs
npm i
npm start
npm start -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the three steps defined above:

cd docs
npm i
npm start``` are out of date; We will turn this //TODO comment into an issue, which @SimonSapin wants to tackle as a followup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve submitted #1036. Maybe undo this chunk here to avoid a merge conflict?

```

This will start up a development server with live reload enabled. You can see the docs by
Expand Down
29 changes: 6 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions apollo-router-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ tracing = "0.1.34"
tracing-opentelemetry = "0.17.2"
typed-builder = "0.10.0"
urlencoding = "2.1.0"
mime = "0.3.16"

[dev-dependencies]
insta = "1.12.0"
Expand Down
Loading