Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate likely unrecoverable watch errors to result handler #588

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Propagate likely unrecoverable watch errors to result handler #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apollo-ios/Sources/Apollo/GraphQLQueryWatcher.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ public final class GraphQLQueryWatcher<Query: GraphQLQuery>: Cancellable, Apollo
if self.refetchOnFailedUpdates && self.fetching.cachePolicy != .returnCacheDataDontFetch {
// If the cache fetch is not successful, for instance if the data is missing, refresh from the server.
self.fetch(cachePolicy: .fetchIgnoringCacheData)
} else {
// Propagate the error so the watcher knows something is wrong.
self.resultHandler(result)
}
}
}
Expand Down