Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuist updates #201

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Tuist updates #201

merged 7 commits into from
Dec 15, 2023

Conversation

BobaFetters
Copy link
Member

@BobaFetters BobaFetters commented Dec 15, 2023

Updating to newest tuist version to get multiplatofmr target support, and making a few tweaks to get rid of some warnings in the generated project

Closes apollographql/apollo-ios#3303

@BobaFetters BobaFetters requested a review from a team as a code owner December 15, 2023 18:02
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 931e822
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/657ccb680fffa400082bc054

@calvincestari
Copy link
Member

It looks like the Run Tuist Generation test was skipped here. We should definitely have that CI test run right?

@BobaFetters
Copy link
Member Author

It looks like the Run Tuist Generation test was skipped here. We should definitely have that CI test run right?

Ah yea didn't think about that since no changes are happening in the Swift code it is skipping the project generation, and I need to bump the version in the CI script

@BobaFetters
Copy link
Member Author

Going to add a sample change to a swift file to trigger the jobs and make sure they pass

Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's causing those test failures. Where is NSImage being used???

But otherwise LGTM

@BobaFetters
Copy link
Member Author

Looks like that fixed, going to remove that test change and merge. Also NSImage is used in URLSessionClientTests

@BobaFetters BobaFetters merged commit ad4c65f into main Dec 15, 2023
13 checks passed
@BobaFetters BobaFetters deleted the tuist-updates branch December 15, 2023 22:14
BobaFetters added a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuist version bump
3 participants