feature: Emit Identifiable conformance on SelectionSets (apollographq…

…l/apollo-ios-dev#584)
apollographql · Jan 24, 2025 · c254f6c · c254f6c
1 parent 38ea614
commit c254f6c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/Sources/ApolloCodegenLib/Templates/SelectionSetTemplate.swift b/Sources/ApolloCodegenLib/Templates/SelectionSetTemplate.swift
@@ -102,7 +102,9 @@ struct SelectionSetTemplate {
       """
       \(SelectionSetNameDocumentation(selectionSet))
       \(renderAccessControl())\
-      struct \(fieldSelectionSetName): \(SelectionSetType()) {
+      struct \(fieldSelectionSetName): \(SelectionSetType())\
+      \(if: selectionSet.isIdentifiable, ", Identifiable")\
+       {
         \(BodyTemplate(context))
       }
       """
@@ -118,6 +120,7 @@ struct SelectionSetTemplate {
       \(renderAccessControl())\
       struct \(inlineFragment.renderedTypeName): \(SelectionSetType(asInlineFragment: true))\
       \(if: inlineFragment.isCompositeInlineFragment, ", \(config.ApolloAPITargetName).CompositeInlineFragment")\
+      \(if: inlineFragment.isIdentifiable, ", Identifiable")\
        {
         \(BodyTemplate(context))
       }

diff --git a/Sources/IR/IR+ComputedSelectionSet.swift b/Sources/IR/IR+ComputedSelectionSet.swift
@@ -1,4 +1,5 @@
 import Foundation
+import GraphQLCompiler
 import OrderedCollections
 import Utilities
 
@@ -18,6 +19,24 @@ public struct ComputedSelectionSet {
 
   /// The `TypeInfo` for the selection set of the computed selections
   public let typeInfo: IR.SelectionSet.TypeInfo
+
+  /// Indicates if the parent type has a single keyField named `id`.
+  public var isIdentifiable: Bool {
+    guard direct?.fields["id"] != nil || merged.fields["id"] != nil else {
+      return false
+    }
+    if let type = typeInfo.parentType as? GraphQLObjectType,
+       type.keyFields == ["id"] {
+      return true
+    }
+
+    if let type = typeInfo.parentType as? GraphQLInterfaceType,
+       type.keyFields == ["id"] {
+      return true
+    }
+
+    return false
+  }
 
   // MARK: Dynamic Member Subscript