manually update various tooling-related dependencies #12286

phryneas · 2025-01-21T13:44:48Z

This should address a lot of the updates in #11959

Also see the build output diff: https://github.com/apollographql/apollo-client/actions/runs/12888464243?pr=12286

changeset-bot · 2025-01-21T13:44:51Z

⚠️ No Changeset found

Latest commit: fe45d68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

svc-apollo-docs · 2025-01-21T13:44:52Z

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 3e14ee0b26b5817fab5d2812

pkg-pr-new · 2025-01-21T13:53:14Z

npm i https://pkg.pr.new/@apollo/client@12286

commit: fe45d68

pkg-pr-new · 2025-01-21T13:53:14Z

npm i https://pkg.pr.new/@apollo/client@12286

commit: cefb838

github-actions · 2025-01-21T13:53:40Z

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	40.66 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	50.07 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	47.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	36.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	33.58 KB (+0.01% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.29 KB (-0.03% 🔽)
import { useLazyQuery } from "dist/react/index.js"	5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.78 KB (+0.03% 🔺)
import { useMutation } from "dist/react/index.js"	3.62 KB (+0.03% 🔺)
import { useMutation } from "dist/react/index.js" (production)	2.84 KB (+0.04% 🔺)
import { useSubscription } from "dist/react/index.js"	4.42 KB (-0.03% 🔽)
import { useSubscription } from "dist/react/index.js" (production)	3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.17 KB (-0.05% 🔽)
import { useBackgroundQuery } from "dist/react/index.js"	5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.35 KB (0%)
import { useFragment } from "dist/react/index.js"	2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.31 KB (0%)

netlify · 2025-01-21T13:53:42Z

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	`fe45d68`
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/678ff43a88171b0008f1f0bc
😎 Deploy Preview	https://deploy-preview-12286--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

phryneas · 2025-01-21T13:56:45Z

eslint.config.mjs

@@ -0,0 +1,175 @@
+import typescriptEslint from "@typescript-eslint/eslint-plugin";


This file was auto-migrated via npx @eslint/migrate-config .eslintrc.

As a result I had to add the new dependencies @eslint/compat globals @eslint/js @eslint/eslintrc

phryneas · 2025-01-21T13:57:53Z

src/errors/index.ts

@@ -77,7 +77,7 @@ const generateErrorMessage = (err: ApolloError) => {
 *
 * Use `ReadonlyArray<GraphQLFormattedError>` instead.
 */
-// eslint-disable-next-line @typescript-eslint/ban-types


ban-types has been removed and been split up into various new rules

see https://typescript-eslint.io/rules/ban-types/

phryneas · 2025-01-21T13:58:29Z

src/react/components/__tests__/client/Mutation.test.tsx

@@ -1526,7 +1526,6 @@ describe("General Mutation testing", () => {
      // expect(waitFor(() => didError)).resolves.toBe(true);
      //
      // ...however it also causes the test to fail against React 17.
-      // eslint-disable-next-line testing-library/await-async-utils


I'm not sure why that rule ever warned here, but it doesn't do that anymore.

phryneas · 2025-01-21T13:58:55Z

src/react/hooks/internal/useDeepMemo.ts

@@ -9,6 +9,7 @@ export function useDeepMemo<TValue>(
  const ref = React.useRef<{ deps: DependencyList; value: TValue }>(void 0);

  if (!ref.current || !equal(ref.current.deps, deps)) {
+    // eslint-disable-next-line react-compiler/react-compiler


New warnings on variables the compiler assumes immutable. I've added ignore comments for all of them.

phryneas · 2025-01-21T13:59:46Z

src/react/hooks/useBackgroundQuery.ts

@@ -190,12 +190,13 @@ export function useBackgroundQuery<
 ] {
  return wrapHook(
    "useBackgroundQuery",
-    _useBackgroundQuery,
+    // eslint-disable-next-line react-compiler/react-compiler
+    useBackgroundQuery_,


_useBackgroundQuery wasn't recognized as a "hook name" anymore, so I had to change it.

New rule on top: hooks cannot be saved into variables or passed as arguments. Generally I agree, but in this pattern it's okay.

phryneas · 2025-01-21T14:00:13Z

src/utilities/globals/__tests__/invariantWrappers.test.ts

@@ -5,7 +5,7 @@ import {
  invariant,
 } from "../invariantWrappers";

-function withDev() {
+function withDev(): typeof import("../../../dev") & AsyncDisposable {


The AsyncDisposable needs to be explicit.

phryneas · 2025-01-21T14:00:46Z

src/cache/index.ts

@@ -49,4 +49,4 @@ export { Policies } from "./inmemory/policies.js";
 export type { FragmentRegistryAPI } from "./inmemory/fragmentRegistry.js";
 export { createFragmentRegistry } from "./inmemory/fragmentRegistry.js";

-export * from "./inmemory/types.js";
+export type * from "./inmemory/types.js";


wildcard type-only exports should also contain type, which seems like a good thing.

phryneas · 2025-01-21T14:01:22Z

.api-reports/api-report-link_persisted-queries.api.md

@@ -63,7 +63,7 @@ interface BaseOptions {
 // Warning: (ae-forgotten-export) The symbol "ApolloLink" needs to be exported by the entry point index.d.ts
 //
 // @public (undocumented)
-export const createPersistedQueryLink: (options: PersistedQueryLink.Options) => ApolloLink & {
+export const createPersistedQueryLink: (options: PersistedQueryLink.Options) => ApolloLink & ({


Additional () caused by api-explorer update

jerelmiller

Thanks for doing this! This was long overdue.

…2286)

phryneas added 10 commits January 21, 2025 13:34

update TS and api-extractor

5d396e7

update typescript-eslint

86feccf

update eslint

7795913

update eslint-plugin-react-compiler

9620523

some more fixup

3b4dd32

format eslint config

0841974

update expect-type

0187956

update ts-api-utils

ed78e7a

update ts-morph

154c978

ignore react-18 in renovate

56d20f5

phryneas added 4 commits January 21, 2025 14:45

update @types/node

a8592a6

pin versions

3974fb7

lockfile

2b7b6b4

remove outdated patch

cefb838

update mocha in memory tests

2a0d0c9

phryneas commented Jan 21, 2025

View reviewed changes

phryneas requested a review from jerelmiller January 21, 2025 18:04

jerelmiller approved these changes Jan 21, 2025

View reviewed changes

github-actions bot added the auto-cleanup 🤖 label Jan 21, 2025

Update size limits

fe45d68

jerelmiller merged commit 12ecde9 into main Jan 21, 2025
46 checks passed

jerelmiller deleted the pr/manual-updates branch January 21, 2025 19:30

Cellule pushed a commit to Cellule/apollo-client that referenced this pull request Jan 22, 2025

manually update various tooling-related dependencies (apollographql#1…

afdf22c

…2286)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

manually update various tooling-related dependencies #12286

manually update various tooling-related dependencies #12286

phryneas commented Jan 21, 2025 •

edited

Loading

changeset-bot bot commented Jan 21, 2025 •

edited

Loading

svc-apollo-docs commented Jan 21, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 21, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 21, 2025

github-actions bot commented Jan 21, 2025 •

edited

Loading

netlify bot commented Jan 21, 2025 •

edited

Loading

phryneas Jan 21, 2025

phryneas Jan 21, 2025

phryneas Jan 21, 2025

phryneas Jan 21, 2025

phryneas Jan 21, 2025

phryneas Jan 21, 2025

phryneas Jan 21, 2025

phryneas Jan 21, 2025

jerelmiller left a comment

		@@ -0,0 +1,175 @@
		import typescriptEslint from "@typescript-eslint/eslint-plugin";

manually update various tooling-related dependencies #12286

manually update various tooling-related dependencies #12286

Conversation

phryneas commented Jan 21, 2025 • edited Loading

changeset-bot bot commented Jan 21, 2025 • edited Loading

⚠️ No Changeset found

svc-apollo-docs commented Jan 21, 2025 • edited Loading

✅ Docs preview has no changes

pkg-pr-new bot commented Jan 21, 2025 • edited Loading

pkg-pr-new bot commented Jan 21, 2025

github-actions bot commented Jan 21, 2025 • edited Loading

size-limit report 📦

netlify bot commented Jan 21, 2025 • edited Loading

✅ Deploy Preview for apollo-client-docs ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jerelmiller left a comment

Choose a reason for hiding this comment

phryneas commented Jan 21, 2025 •

edited

Loading

changeset-bot bot commented Jan 21, 2025 •

edited

Loading

svc-apollo-docs commented Jan 21, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

netlify bot commented Jan 21, 2025 •

edited

Loading