-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @mask
directive
#11896
feat: add @mask
directive
#11896
Conversation
👷 Deploy request for apollo-client-docs pending review.Visit the deploys page to approve it
|
|
Hey @vladar 👋 Thanks for the PR! Just an FYI, I'm still working through the data masking implementation and getting the APIs added to the appropriate spots in the codebase. I've got my in-progress work on the data-masking branch. The changes there may change significantly between now and any public release, so just be aware that anything you add in this PR may require refactoring to work with the changes introduced in that branch. I'd hate for you to spend a bunch of time maintaining this branch as things are still in flux. Until I'm a little further along in the implementation and determine whether the |
@jerelmiller this is just a playground PR, mostly for you if you want to play with |
Got it. Appreciate the context! |
Hey @vladar 👋 Thanks for your patience! We've had several team discussions and still really believe that the I agree with you that having a way to try out the data masking feature in a small subset of places is valuable. We will likely instead recommend in these cases that you create a separate client instance with the Regardless, we'll try and include some kind of recommendation in our docs if you're looking for a "just try it out" approach. As such, I'm going to go ahead and close this out. Thanks again for the PR and the idea! |
Work in progress
Initial implementation of the
@mask
directive as discussed here: #11666 (comment).A potential solution for #11514