move target="_blank" rel="noopener noreferrer" into ExternalLink

apollographql · Dec 4, 2024 · 10ac491 · 10ac491
1 parent e2d4385
commit 10ac491
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 25 deletions.
diff --git a/src/application/components/ExternalLink.tsx b/src/application/components/ExternalLink.tsx
@@ -4,5 +4,5 @@ export const ExternalLink = forwardRef<
   HTMLAnchorElement,
   ComponentProps<"a"> & { href: string }
 >((props, ref) => {
-  return <a {...props} ref={ref} />;
+  return <a target="_blank" rel="noopener noreferrer" {...props} ref={ref} />;
 });
diff --git a/src/application/components/GitHubIssueLink.tsx b/src/application/components/GitHubIssueLink.tsx
@@ -63,8 +63,6 @@ export const GitHubIssueLink = forwardRef<
       {...props}
       ref={ref}
       className={className}
-      rel="noreferrer noopener"
-      target="_blank"
       href={`https://github.com/apollographql/${repository}/issues/new?${params}`}
     >
       {children}

diff --git a/src/application/components/GitHubReleaseHoverCard.tsx b/src/application/components/GitHubReleaseHoverCard.tsx
@@ -72,8 +72,6 @@ function SnapshotCardContents({ version }: { version: SnapshotVersion }) {
             <ExternalLink
               className="flex gap-1 items-center mt-2"
               href={`https://github.com/apollographql/apollo-client/pull/${release.prNumber}`}
-              target="_blank"
-              rel="noreferrer"
             >
               View pull request in GitHub <IconOutlink className="size-3" />
             </ExternalLink>

diff --git a/src/application/components/Modals/ClientNotFoundModal.tsx b/src/application/components/Modals/ClientNotFoundModal.tsx
@@ -12,11 +12,7 @@ interface ClientNotFoundModalProps {
 
 function ConnectToDevToolsOptionLink() {
   return (
-    <ExternalLink
-      rel="noreferrer noopener"
-      target="_blank"
-      href="https://www.apollographql.com/docs/react/api/core/ApolloClient#apolloclientoptions-connecttodevtools"
-    >
+    <ExternalLink href="https://www.apollographql.com/docs/react/api/core/ApolloClient#apolloclientoptions-connecttodevtools">
       <code>connectToDevTools</code> option
     </ExternalLink>
   );
@@ -73,11 +69,7 @@ ${SECTIONS.devtoolsVersion}
               <p className="mt-4">
                 You may need to tweak your bundler settings to set{" "}
                 <code>globalThis.__DEV__</code> correctly. See the{" "}
-                <ExternalLink
-                  rel="noreferrer noopener"
-                  target="_blank"
-                  href="https://www.apollographql.com/docs/react/development-testing/reducing-bundle-size/"
-                >
+                <ExternalLink href="https://www.apollographql.com/docs/react/development-testing/reducing-bundle-size/">
                   &quot;Reducing bundle size&quot;
                 </ExternalLink>{" "}
                 article for examples on configuring your bundler.
@@ -108,11 +100,7 @@ ${SECTIONS.devtoolsVersion}
             <Disclosure.Panel>
               Apollo Client Devtools does not currently support clients created
               in iframes. Please follow{" "}
-              <ExternalLink
-                rel="noreferrer noopener"
-                target="_blank"
-                href="https://github.com/apollographql/apollo-client-devtools/discussions/380"
-              >
+              <ExternalLink href="https://github.com/apollographql/apollo-client-devtools/discussions/380">
                 this discussion
               </ExternalLink>{" "}
               for updates on this feature.
@@ -129,11 +117,7 @@ ${SECTIONS.devtoolsVersion}
                 <code>window.__APOLLO_CLIENT__</code> variable for up to 10
                 seconds after a page load before giving up. When using
                 Apollo&apos;s{" "}
-                <ExternalLink
-                  rel="noreferrer noopener"
-                  target="_blank"
-                  href="https://github.com/apollographql/apollo-client-nextjs"
-                >
+                <ExternalLink href="https://github.com/apollographql/apollo-client-nextjs">
                   Next.js RSC integration
                 </ExternalLink>
                 , it is possible that Apollo Client Devtools will be unable to