Fix bug with get_node_by_id #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. Add remove_node to writable methods for InMemoryCachedBackend.
|
grr, broken codspeed CI... one sec! trying to resolve in #60 |
j6k4m8
approved these changes
Dec 8, 2024
VERY MUCH appreciate this! But whenever possible I am excited to get your PRs merged in upstream as quickly as possible — will try my best to keep this moving rapidly to stay off your critical path! It's always awesome to see a PR coming from you and know that the ecosystem is about to get better!! This change is now live on PyPI in |
|
Much appreciated! Everything is working on my end with these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple other things while testing as follows:
get_node_by_id. This makes the behavior consistent withget_edge_by_id.remove_nodeto writable methods forInMemoryCachedBackend. This fixes a caching issue when a node is removed.I want to be respectful of your time, so I can handle these changes locally until you have time to integrate and push a release. Thanks again for all the help!