Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove_node method to SQLBackend #58

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Conversation

davidmezzetti
Copy link
Contributor

@davidmezzetti davidmezzetti commented Dec 7, 2024

This PR makes the following changes:

  • Adds remove_node method to the SQLBackend per the NetworkXDialect
  • Changes setup.py to limit numpy < 2.0 when using the networkit extra
  • Changes has_node to return a bool vs int to conform with dialect standard

Copy link

codspeed-hq bot commented Dec 7, 2024

CodSpeed Performance Report

Merging #58 will not alter performance

Comparing davidmezzetti:master (76783b0) with master (71286f3)

🎉 Hooray! pytest-codspeed just leveled up to 3.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 4 untouched benchmarks

Copy link
Member

@j6k4m8 j6k4m8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Will merge and roll a patch to PyPI :)

@j6k4m8 j6k4m8 merged commit e07b8d4 into aplbrain:master Dec 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants