Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add +1 check for max pages and improve the coutner keeping #47

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

foxt451
Copy link
Contributor

@foxt451 foxt451 commented Jan 10, 2024

Improves the checks a bit
Closes #45
It's not always reproducible, but I've done a couple of runs and it always finished with 10 requests exactly.

@foxt451 foxt451 self-assigned this Jan 10, 2024
Copy link
Contributor

@metalwarrior665 metalwarrior665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I like yours better

Copy link
Contributor

@metalwarrior665 metalwarrior665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one potentially problematic thing is that is requests start failing, we will not have any more and users will get less results. But let's keep it unless someone complains, should be super rare

@metalwarrior665
Copy link
Contributor

fyi going with this @Patai5

@metalwarrior665 metalwarrior665 merged commit 679e3b1 into master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actor doesn't correctly finish when reaching max scraped pages
2 participants