Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore 2.1 march17 #726

Closed
wants to merge 7 commits into from
Closed

Explore 2.1 march17 #726

wants to merge 7 commits into from

Conversation

KenCarvAPI
Copy link

Update to explore

  • Please review the OEV additions
  • Need to update market photos on the dAPI page
  • Formatting might need to be worked through further

You can head to the [API3 Market](https://market.api3.org/dapis) to explore this
further.

<!--## Self-funded dAPIs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple comment <!-- tags between these comments that cause the build to fail. Maybe delete the commented sections?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for just deleting- git preserves a history so if any deleted comment was ever needed (doubtful) it could be recovered

docs/explore/dapis/what-are-dapis.md Show resolved Hide resolved
Refer to these guides and learn how to activate and read the dAPI using a proxy
contract:

- [Subscribing to Self-Funded dAPIs](/guides/dapis/subscribing-self-funded-dapis/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the self-funded dAPI references.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've switched this to 'activating a dAPI' and it should link to the lead 'how to activate a dAPI' with the new market UI. I'm unsure of the URL in the docs, Vansh could you add this?

CleanShot 2024-04-26 at 14 00 34

docs/explore/dapis/using-dapis.md Show resolved Hide resolved
docs/explore/dapis/using-dapis.md Show resolved Hide resolved
docs/explore/dapis/using-dapis.md Show resolved Hide resolved
docs/explore/dapis/security-considerations.md Show resolved Hide resolved
docs/explore/dapis/OEV.md Show resolved Hide resolved
docs/explore/sidebar.js Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads similar to explore/dapis/OEV.md. Maybe we delete the old OEV.md page and move this under explore/dapis

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I've just the dAPI OEV section down a little to stop duplication.

Until I see the wider OEV materials I think keeping it like this is ok. I'm pretty sure we'll need to review this as the wider documentation is public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants