Log full data with delay #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Sep 10, 2024
| PostSignedDataResponseSchema, | ||
| } from './types'; | ||
| import { extractBearerToken, generateErrorResponse, isBatchUnique } from './utils'; | ||
|
|
||
| const env = loadEnv(); | ||
| const LOG_API_DATA_DELAY_MS = 5 * 60 * 1000; |
There was a problem hiding this comment.
I think a hardcoded delay is good enough.
There was a problem hiding this comment.
Yes it looks okay unless we set delaySeconds to more than 5 minutes.
bdrhn9
approved these changes
Sep 10, 2024
| PostSignedDataResponseSchema, | ||
| } from './types'; | ||
| import { extractBearerToken, generateErrorResponse, isBatchUnique } from './utils'; | ||
|
|
||
| const env = loadEnv(); | ||
| const LOG_API_DATA_DELAY_MS = 5 * 60 * 1000; |
There was a problem hiding this comment.
Yes it looks okay unless we set delaySeconds to more than 5 minutes.
| logged with the fields `airnode`, `encodedValue`, `templateId`, and `timestamp`. The `signature` field is intentionally | ||
| excluded for security reasons. Options: | ||
| logged with the fields `airnode`, `encodedValue`, `templateId`, `timestamp` and `signature`. The logging of this data is | ||
| delayed to make sure people with access to the logs won't be able to misuse the beacon data. Options: |
There was a problem hiding this comment.
Nit: maybe we can mention how much logging is delayed because it is already hard-coded to 5 minutes.
Yeah, but such data is practically unusable so I don't see us doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364