chore(deps): update non-major-devdependencies (#354)

* chore(deps): update non-major-devdependencies * Use newer eslint commons * Remove useless overrides * Self review * Fix always truthy expression --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Emanuel Tesař <[email protected]>
api3dao · Sep 25, 2024 · 751393a · 751393a
1 parent 018ce72
commit 751393a
Show file tree

Hide file tree

Showing 11 changed files with 679 additions and 1,105 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -3,13 +3,5 @@ module.exports = {
   parserOptions: {
     project: ['./tsconfig.json', './packages/*/tsconfig.json'],
   },
-  rules: {
-    '@typescript-eslint/prefer-destructuring': 'off', // The commons universal ESLint configuration already uses "prefer-destructuring" and this extended version is not needed.
-    '@typescript-eslint/max-params': 'off', // It is sometimes necessary to have enough arguments. This rule is too strict.
-
-    '@typescript-eslint/prefer-nullish-coalescing': 'off', // This rule throws an error with ESLint plugin and parser @6.19.0.
-    '@typescript-eslint/consistent-return': 'off', // Triggers multiple false positives, e.g. in exhaustive switch cases or zod transformations.
-
-    'jest/prefer-importing-jest-globals': 'off',
-  },
+  rules: {},
 };
diff --git a/jest.setup.js b/jest.setup.js
@@ -17,4 +17,4 @@ Object.defineProperty = function (object, name, meta) {
 };
 
 // Disable logger if it is not explicitly set to true.
-process.env.LOGGER_ENABLED = process.env.LOGGER_ENABLED || 'false';
+process.env.LOGGER_ENABLED = process.env.LOGGER_ENABLED ?? 'false';
diff --git a/package.json b/package.json
@@ -27,22 +27,17 @@
   "license": "MIT",
   "devDependencies": {
     "@api3/commons": "0.13.2",
-    "@api3/eslint-plugin-commons": "^2.0.1",
-    "@types/jest": "^29.5.12",
-    "@types/node": "^20.14.13",
-    "@typescript-eslint/eslint-plugin": "^8.0.0",
-    "@typescript-eslint/parser": "^8.0.0",
-    "eslint": "^8.57.0",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jest": "^28.6.0",
-    "husky": "^9.1.4",
+    "@api3/eslint-plugin-commons": "^3.0.0",
+    "@types/jest": "^29.5.13",
+    "@types/node": "^20.16.5",
+    "husky": "^9.1.6",
     "is-wsl": "^2.2.0",
     "jest": "^29.7.0",
     "prettier": "^3.3.3",
     "rimraf": "^6.0.1",
-    "ts-jest": "^29.2.3",
+    "ts-jest": "^29.2.5",
     "ts-node": "^10.9.2",
-    "typescript": "^5.5.4"
+    "typescript": "^5.6.2"
   },
   "packageManager": "[email protected]"
 }
diff --git a/packages/airnode-feed/package.json b/packages/airnode-feed/package.json
@@ -46,6 +46,6 @@
   "devDependencies": {
     "@types/express": "^4.17.21",
     "@types/lodash": "^4.17.7",
-    "nodemon": "^3.1.4"
+    "nodemon": "^3.1.5"
   }
 }
diff --git a/packages/e2e/src/data-provider-api.ts b/packages/e2e/src/data-provider-api.ts
@@ -3,7 +3,7 @@ import express from 'express';
 import { logger } from './logger';
 
 const app = express();
-const PORT = 9876 || process.env.PORT;
+const PORT = process.env.PORT ?? 9876;
 
 interface Asset {
   value: number;

diff --git a/packages/performance-test/airnode-feed/initialize-source-api/start-airnode-feeds.ts b/packages/performance-test/airnode-feed/initialize-source-api/start-airnode-feeds.ts
@@ -3,7 +3,7 @@ import { readFileSync, writeFileSync } from 'node:fs';
 import { join } from 'node:path';
 
 import { ethers } from 'ethers';
-import prettier from 'prettier';
+import { resolveConfig, format } from 'prettier';
 
 // The script creates a random mnemonic and writes it into airnode-feed.json configuration and starts an Airnode feed
 // service which reads this configuration and sets the Signed API (as specified in the configuration). These Airnode
@@ -51,8 +51,8 @@ const main = async () => {
   const configPath = join(__dirname, 'config/airnode-feed.json');
   const config = JSON.parse(readFileSync(configPath, 'utf8'));
   config.nodeSettings.airnodeWalletMnemonic = mnemonic;
-  const options = await prettier.resolveConfig(configPath);
-  const formattedFile = await prettier.format(JSON.stringify(config, null, 2), { ...options, parser: 'json' });
+  const options = await resolveConfig(configPath);
+  const formattedFile = await format(JSON.stringify(config, null, 2), { ...options, parser: 'json' });
   writeFileSync(configPath, formattedFile);
 
   // Start the Airnode feed service.
@@ -64,7 +64,6 @@ const main = async () => {
   console.info(`Worker ${process.env.SERVICE_DIR} finished`);
 
   // Kill the worker.
-  // eslint-disable-next-line unicorn/no-process-exit
   process.exit(0);
 };
 

diff --git a/packages/signed-api/package.json b/packages/signed-api/package.json
@@ -31,7 +31,7 @@
   "devDependencies": {
     "@types/express": "^4.17.21",
     "@types/lodash": "^4.17.7",
-    "nodemon": "^3.1.4",
+    "nodemon": "^3.1.5",
     "ts-node": "^10.9.2"
   },
   "dependencies": {

diff --git a/packages/signed-api/src/index.ts b/packages/signed-api/src/index.ts
@@ -20,6 +20,7 @@ const setupUncaughtErrorHandler = () => {
   process.on('unhandledRejection', () => process.exit(1));
 };
 
+// eslint-disable-next-line import/no-named-as-default-member
 const portSchema = z.coerce.number().int().positive();
 
 // Start the Signed API. All application errors should be handled by this function (or its callees) and any error from

diff --git a/packages/signed-api/src/npm-exports.ts b/packages/signed-api/src/npm-exports.ts
@@ -1,5 +1,5 @@
 // NOTE: This file defines the NPM exports. Everything that should be available to import from the NPM package should be
 // exported here.
 export * from './schema';
-export * from './types';
+export type * from './types';
 export * from './utils';