Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cmake issue #2021

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: cmake issue #2021

merged 2 commits into from
Jan 30, 2025
+11 −2

Conversation

Shr1ftyy
Copy link
Contributor

resolves #2020

@bbenligiray bbenligiray requested a review from dcroote September 19, 2024 07:37
dcroote
dcroote reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation and PR. It looks fine, but frustratingly the CI step that would test this is failing due to #2022, which I'm going to work on

dcroote
dcroote approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this - the failing CI steps are because of lack of repo secret privileges so I'll merge.

@dcroote dcroote merged commit c5aef44 into api3dao:master Jan 30, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake error on MacOS when building airnode image
2 participants
@Shr1ftyy @dcroote