Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove goerli and polygon mumbai deployments #1991

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Apr 26, 2024

Closes #1988

@dcroote dcroote requested a review from Siegrift April 26, 2024 06:00
@dcroote dcroote self-assigned this Apr 26, 2024
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't spotted any remnants of Goerli and Polygon mumbai and changes LGTM, but I see the contract verification script is failing.

@dcroote
Copy link
Contributor Author

dcroote commented Apr 26, 2024

Yes, for that I created #1992 since it seems unrelated to the changes I made here. I'll investigate and open a PR for that then merge this.

@dcroote
Copy link
Contributor Author

dcroote commented Apr 27, 2024

🤦 the error was because I forgot to actually remove polygon-testnet (I only removed polygon-zkevm-goerli-testnet).

(the gnosis failure is intermittent e.g. fine here: https://github.com/api3dao/airnode/actions/runs/7825972140/job/21351086763)

@dcroote dcroote requested a review from Siegrift April 27, 2024 06:09
@Siegrift
Copy link
Contributor

the error was because I forgot to actually remove polygon-testnet (I only removed polygon-zkevm-goerli-testnet)

I see. I only checked the code (and not filenames).

@dcroote
Copy link
Contributor Author

dcroote commented Apr 27, 2024

Yea, my silly mistake. Mind approving then?

Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote dcroote merged commit 0bb350f into master Apr 29, 2024
28 of 29 checks passed
@dcroote dcroote deleted the dcroote/issue1988 branch April 29, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove goerli deployments
2 participants