Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ANTLR ATN version conflict between hibernate and cqengine #6290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucastheisen
Copy link

  • Brief description of changes applied
  • Test cases for all modified changes, where applicable
    • N/A, i could not come up with a small enough scenario
  • The same pull request targeted at the master branch, if applicable
    • N/A, this PR is already targeted at master
  • Any documentation on how to configure, test
    • N/A there is no documentation as it is a very minor build time change and to test, you would need to start up a cas that used both the google MFA and audit JPA and you got all the way through the authentication workflow to the point you got a response back from the google authenticator MFA (at least that is the point where this was failing from me and no longer does).
  • Any possible limitations, side effects, etc
    • There are no limitations, and the only known side effect is a slighly larger dependency per the upstream maintainer of cqengine
  • Reference any other pull requests that might be related
    • N/A this PR is a standalone

Copy link
Member

@mmoayyed mmoayyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. Please put together a reproducer/test using the instructions provided in the PR template to demonstrate the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants