check rejected or non-monotonically liked outputs in issuePayload (io…

…taledger#1151) * check rejected or non-monotonically outputs * Fix imports Co-authored-by: capossele <[email protected]>
apenzk · Mar 29, 2021 · 04581b3 · 04581b3
1 parent b72204b
commit 04581b3
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/packages/tangle/errors.go b/packages/tangle/errors.go
@@ -2,5 +2,9 @@ package tangle
 
 import "errors"
 
-// ErrNotSynced is triggered when somebody tries to issue a Payload before the Tangle is fully synced.
-var ErrNotSynced = errors.New("tangle not synced")
+var (
+	// ErrNotSynced is triggered when somebody tries to issue a Payload before the Tangle is fully synced.
+	ErrNotSynced = errors.New("tangle not synced")
+	// ErrInvalidInputs is returned when one or more inputs are rejected or non-monotonically liked.
+	ErrInvalidInputs = errors.New("one or more inputs are rejected or non-monotonically liked")
+)
diff --git a/packages/tangle/tangle.go b/packages/tangle/tangle.go
@@ -1,6 +1,7 @@
 package tangle
 
 import (
+	"strings"
 	"sync"
 
 	"github.com/iotaledger/hive.go/autopeering/peer"
@@ -12,6 +13,7 @@ import (
 	"github.com/mr-tron/base58"
 	"golang.org/x/xerrors"
 
+	"github.com/iotaledger/goshimmer/packages/ledgerstate"
 	"github.com/iotaledger/goshimmer/packages/markers"
 	"github.com/iotaledger/goshimmer/packages/tangle/payload"
 )
@@ -114,6 +116,25 @@ func (t *Tangle) IssuePayload(payload payload.Payload) (message *Message, err er
 		return
 	}
 
+	if payload.Type() == ledgerstate.TransactionType {
+		var invalidInputs []string
+		transaction := payload.(*ledgerstate.Transaction)
+		for _, input := range transaction.Essence().Inputs() {
+			if input.Type() == ledgerstate.UTXOInputType {
+				t.LedgerState.OutputMetadata(input.(*ledgerstate.UTXOInput).ReferencedOutputID()).Consume(func(outputMetadata *ledgerstate.OutputMetadata) {
+					t.LedgerState.BranchDAG.Branch(outputMetadata.BranchID()).Consume(func(branch ledgerstate.Branch) {
+						if branch.InclusionState() == ledgerstate.Rejected || !branch.MonotonicallyLiked() {
+							invalidInputs = append(invalidInputs, input.Base58())
+						}
+					})
+				})
+			}
+		}
+		if len(invalidInputs) > 0 {
+			return nil, xerrors.Errorf("invalid inputs: %s: %w", strings.Join(invalidInputs, ","), ErrInvalidInputs)
+		}
+	}
+
 	return t.MessageFactory.IssuePayload(payload)
 }