Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix slice init length #8091

Merged
merged 1 commit into from
Oct 5, 2024
Merged

fix: fix slice init length #8091

merged 1 commit into from
Oct 5, 2024

Conversation

cuishuang
Copy link
Contributor

The intention here should be to initialize a slice with a capacity of length rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Grove
  • CDN in a Box
  • Automation
  • unknown

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

zrhoffman
zrhoffman approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zrhoffman zrhoffman merged commit c27d3d9 into apache:master Oct 5, 2024
40 of 41 checks passed
@zrhoffman zrhoffman added bug something isn't working as intended Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one grove related to the "grove" HTTP caching server implementation labels Oct 5, 2024
@cuishuang cuishuang mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrhoffman zrhoffman zrhoffman approved these changes

Assignees
No one assigned
Labels
bug something isn't working as intended grove related to the "grove" HTTP caching server implementation low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuishuang @zrhoffman