-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Origins page Traffic Portal v2 #7881
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7881 +/- ##
=============================================
+ Coverage 29.06% 65.78% +36.71%
Complexity 98 98
=============================================
Files 605 329 -276
Lines 77535 13038 -64497
Branches 90 1001 +911
=============================================
- Hits 22539 8577 -13962
+ Misses 52908 4100 -48808
+ Partials 2088 361 -1727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you opened this PR to look for feedback, even though it's still a draft. I realize parts of it aren't ready for that yet, but I commented on them a couple times anyway, just in case. The table controller looks mostly good, although I haven't compared it to the functionality of the TPv1 counterpart. Obviously testing needs a lot of work.
I'm gonna try to work on migrating our tests to cypress over the holidays, which will hopefully make the e2e testing easier.
experimental/traffic-portal/src/app/core/origins/detail/origin-detail.component.html
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/origins/detail/origin-detail.component.spec.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/origins/detail/origin-detail.component.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/origins/table/origins-table.component.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/origins/table/origins-table.component.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/origins/table/origins-table.component.ts
Outdated
Show resolved
Hide resolved
Yeah, I made it in draft because it's not ready for review yet. But thanks for your review, I'll check it. The code is copied from some other components and some parts I didn't change it ^^ |
@ocket8888 Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do also still have to check the coverage; need to make sure it hits 100% in the modified files.
experimental/traffic-portal/src/app/core/origins/detail/origin-detail.component.ts
Show resolved
Hide resolved
* | ||
* @param e HTML form submission event. | ||
*/ | ||
public async submit(e: Event): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is not tested
|
||
/** Defines what the table should do when a row is double-clicked. */ | ||
public doubleClickLink: DoubleClickLink<RequestOriginResponse> = { | ||
href: (row: RequestOriginResponse): string => `/core/origins/${row.id}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though it seems pedantic and trivial, testing this object's href
method is the only thing preventing this file from having 100% coverage.
Origins is currently redirecting to Traffic Portal. So that's why I add Origins to Traffic Portal v2
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist