3400: Changed variable name from measurementID to measureName

[RohitGavale]

Renamed the variable name from measurementID to measureName in dropMeasurementSeries Method. Changed the @PathVariable annotation to use measureName instead of measurementID.

[tenthe]

Hi @RohitGavale,
Thank you very much for your PR, we really appreciate it.

For this PR, the clients that call the REST interface also need to be updated, can you please adjust this?
If you have any questions or problems, just write us. We are happy to help you.

[RohitGavale]

Hi @RohitGavale, Thank you very much for your PR, we really appreciate it.

For this PR, the clients that call the REST interface also need to be updated, can you please adjust this? If you have any questions or problems, just write us. We are happy to help you.

Could you confirm if the expectation is to update measurementID to measurementName in all client calls to align with the changes made in the REST interface?

[tenthe]

Yes, exactly.

[RohitGavale]

I have made a pull request.

[tenthe]

Hi @RohitGavale,

Thank you for updating your PR in #3402! I really appreciate your effort.

To clarify, there’s no need to open a new PR for the requested changes—you can make the updates directly in this one.

My earlier comment might have been unclear, sorry for that. I’d like to refine it: I didn’t mean for you to modify the other methods within the DataLakeResourceV4 class. Instead, I was referring specifically to the TypeScript client that interacts with this REST interface. Could you please update the naming in the datalake-rest.service.ts file, particularly for the dropSingleMeasurementSeries method?

Here’s my suggestion:

• Let’s focus on addressing the required updates in this PR, keeping the scope manageable.
• Changes to the naming of other interfaces can be handled in a separate issue or PR.

Additionally, to resolve the failing tests for this PR, you’ll need to adapt the variable name in the @DeleteMapping annotation, as you already did in your other PR.

I hope this comment is helpful.
Thank you again for your work and contributions.

Cheers,
Philipp

[github-actions]

Hello there 👋

We noticed that it's been some time since activity occurred on your pull request 🤔. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed ⏰.

Please take a moment to review your pull request and make any necessary updates or changes 👨‍💻. If you need more time or have any questions, please don't hesitate to let us know 💬.

Thank you for your contributions to our project, and we look forward to hearing back from you soon 🙏.

[github-actions]

Hello there 👋

Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it 🙌.

Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed 💻.

Thank you for your contributions to our project, and we hope to see you again soon!