[SPARK-50941][ML][PYTHON][CONNECT] add supports for TrainValidationSplit #49688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Access the train ratio | ||
| self.assertEqual(tvs_model.getTrainRatio(), 0.75) | ||
| print("----------- ", tvs_model.validationMetrics) |
zhengruifeng
approved these changes
Jan 27, 2025
zhengruifeng
added a commit
that referenced
this pull request
Jan 27, 2025
### What changes were proposed in this pull request? This PR adds support for TrainValidationSplit and TrainValidationSplitModel on Connect ### Why are the changes needed? new feature parity ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? The CI passes ### Was this patch authored or co-authored using generative AI tooling? No Closes #49688 from wbo4958/train_validation_split. Lead-authored-by: Bobby Wang <[email protected]> Co-authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]> (cherry picked from commit 9d0e888) Signed-off-by: Ruifeng Zheng <[email protected]>
|
merged to master/4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds support for TrainValidationSplit and TrainValidationSplitModel on Connect
Why are the changes needed?
new feature parity
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
The CI passes
Was this patch authored or co-authored using generative AI tooling?
No