-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-50979][CONNECT] Remove .expr/.typedExpr implicits #49657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this looks like a safe clean-up. BTW, are these all of them, @hvanhovell ?
Based on failed test, there may be user facing change as plan changes. |
Oh, ya. The plan becomes different.
|
Please update "Does this PR introduce any user-facing change?" |
@vrozov I does not really introduce a user facing change. I actually improved the origin for these cases. |
Merging. |
### What changes were proposed in this pull request? This PR removed the .expr/.typedExpr Column conversion implicits from the Connect client. ### Why are the changes needed? Code clean-up. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49657 from hvanhovell/SPARK-50979. Authored-by: Herman van Hovell <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 6bbfa2d) Signed-off-by: Herman van Hovell <[email protected]>
Thank you, @hvanhovell . |
What changes were proposed in this pull request?
This PR removed the .expr/.typedExpr Column conversion implicits from the Connect client.
Why are the changes needed?
Code clean-up.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.