SOLR-17581: Less ZK watches in tests. #3036
Conversation
Introduce new test variant of waitForState(), that does not wait on live node changes when we're only interested in the collection state.
github-actions
bot
added
test-framework
client:solrj
module:hdfs
tests
cat:search
cat:cloud
cat:index
labels
solr/solrj/src/test/org/apache/solr/common/cloud/PerReplicaStatesIntegrationTest.java
Show resolved
Hide resolved
| return predicate.test(c); | ||
| }); | ||
| } catch (Exception e) { | ||
| fail(message + "\n" + e.getMessage() + "\nLast available state: " + state.get()); |
There was a problem hiding this comment.
didn't propagate 'e'; can't we throw it before logging the last available state?
There was a problem hiding this comment.
I wanted to do the same as existing variant of waitForState() (the one that watches both live nodes and the collection).
I think the two methods should be aligned. I think it makes sense to raise a JUnit specific error. Most of the time, the caught exception has no interesting details, it's just a timeout.
Not new but fair! I dislike parameter order since I've been looking at these methods. |
Introduce new test variant of waitForState(), that does not wait on live node changes when we're only interested in the collection state. This is a test change only. (cherry picked from commit bbbff85)
https://issues.apache.org/jira/browse/SOLR-17581
Description
Test creates lot of useless Zookeeper watches, because all waitForState() create a watch both on the collection state and the list of live nodes. Most of calls ignore live nodes when evaluating the predicate.
Solution
Introduce new test variant of waitForState(), that does not wait on live node changes when we're only interested in the collection state.
Tests
This is a test only change.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.