SOLR-6122 POC new cancel handler for Collections api #3033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-6122
Description
This PR implemented a new overseer level message handler to cancel submitted & in-progress collections api calls. As an example, this PR only opt-in backup collection api for in-progress cancel.
in-progress collections api calls are not complete, as core level cancel is not implemented. Current implemention removes tracking of in-progress collections api from overseers, which can be useful in some situation like backup.
Solution
General flow:
-> Client request cancle with async ID through
http://localhost:8983/solr/admin/collections?action=CANCEL&requestid=1
-> Cancel message handled by
OverseerCancelMessageHandler
to determine if this asyncId exist and if it's currently in submitted or in-progress state :workQueue
and clearblockedTasks
in case submitted task is in blocked tasksisInProgressCancelable
-> remove in-progress tasks from tracking queues in overseerworkQueue
&runningMap
&runningTasks
Api:
New V2 api interface for cancel handler
Overseer:
OverseerTaskQueue
to handle remove / get item from queue given zk pathOverseerCancelMessageHandler:
Tests
Test locally through CURL, working on testing
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.