-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17609: Remove HDFS module #2923
base: main
Are you sure you want to change the base?
Conversation
Question! Should |
Opportunity to remove the |
… HDFS" This reverts commit e8801bd.
…running HDFS? Is this it's own thing?
This reverts commit a4dc815.
I think this is ready for review! I don't plan on merging it till we get some more consensus. One thing I need eyes on: the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the log or test XML config files that had harmless references to HDFS, it's good to see this change is mostly very contained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose that the "blockcache" java package, and corresponding tests, be moved into the solr-core module.
The javadocs for the BlockCache package is misleading. It says "An HDFS blockcache implementation" but the BlockCache actually has no outwards dependencies aside from Lucene and basic stuff. A more accurate characterization of the package is: "A generic Directory layer/wrapper that caches data, on or off heap as desired". This is a hidden gem with remarkable intellectual property that our project will hopefully use on top of another Directory. For example if DirectoryFactory uses NIO better, we might very well use this with GCP FileSystemProvider, which just so happens to already be in our dependencies.
It's february 1st, so I'm going to look to merge this on Monday barring any other concerns being brought up. |
https://issues.apache.org/jira/browse/SOLR-17609
Description
Explore what removing HDFS module from Solr impacts.
Solution
Searching for references for
hdfs
,hadoop
, and other keywords. Running tests.libs.versions.toml
Tests
Only existing tests.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.