Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17302: Convert /cluster filestore APIs to JAX-RS (reinstating after revert) #2507

Conversation

gerlowskija
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17302

Description

This PR brings back code originally introduced in PR #2470. The code was merged initially last week, but I noticed a bug in helping with a different PR and decided to revert until I had time to fix. (Some discussion of that here).

This PR reintroduces all of the code that was already reviewed and merged in #2470, while fixing the bug that caused reversion (an issue with our OAS code generation template).

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.

@gerlowskija
Copy link
Contributor Author

With the exception of the api.mustache changes, everything in this PR has already been reviewed in #2470 , so I'm going to merge it fairly quickly so that it can be in the weekend's test runs. (I'm still happy to address feedback here, if anyone has comments)

@gerlowskija gerlowskija merged commit 2636567 into apache:main Jun 7, 2024
4 checks passed
@gerlowskija gerlowskija deleted the SOLR-17302-reinstate-filestore-jaxrs-conversion branch June 7, 2024 14:12
gerlowskija added a commit that referenced this pull request Jun 7, 2024
…ter revert) (#2507)

This commit moves some of Solr's "filestore" APIs (those located under
the `/api/cluster/files` path) to JAX-RS.

(This code was previously committed and reverted, and is now
reintroduced in this commit with a few minor fixes.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant