Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16466: Admin UI - Make it optional to sort list of commandline args #2246

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

freedev
Copy link
Contributor

@freedev freedev commented Feb 6, 2024

https://issues.apache.org/jira/browse/SOLR-16466

Description

Added a call to action (checkbox) at end of JVM Command-Line Arguments.
The arguments are unsorted (original order) by default , when the checkbox is selected the arguments are sorted lexicographically.

Solution

Added a checkbox in the dashboard at end of JVM Command-Line Arguments.
Changed Angular IndexController (the component behind the Admin Dashboard):

  • changed reload function: save a copy of the original commandline args and check the order
  • Added toggleCommandLineOrder function - handle the checkbox click
  • Added showCommandLineArgs function - show the args list with the correct order

Tests

I have tested the changes locally running solr standalone

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

* main:
  Add bugfix version 8.11.3
  Add 8.11.3 release to DOAP RDF file
  SOLR-16858: KnnQParser's "Pre-Filtering" behavior is now controlable via local params (closes apache#2157)
  SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 (apache#2240)
  dev-docs + help: try-and-tweak 'Solr X Lucene' docs (apache#2223)
  SOLR-17152: Better alignment of Admin UI graph (apache#2249)
  SOLR-15960: Find unexported variables with compgen (apache#2250)
  fix a few typos in the Indexing Guide (apache#2245)
  SOLR-17149: Fix backup/restore for large collections. (apache#2243)
  SOLR-17146: Add DelegatingBackupRepository and alternative checksum verification (apache#2239)
  Revert "Revert "SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 2 (apache#2231)""
  SOLR-17038: /admin/segments handler: Expose the term count (apache#2233)
Copy link
Contributor

@elyograg elyograg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I am a novice at web app design. Nothing looks bad to me in the patch.

solr/CHANGES.txt Outdated Show resolved Hide resolved
@cpoerschke
Copy link
Contributor

Hello again!

I'd love to see this included in the upcoming 9.6 release -- https://lists.apache.org/thread/mn6625txw938l8sy1o9r9rhmnqpdfo6v

@elyograg - would you have bandwidth to merge and cherry-pick/backport to branch_9x here or would it be more convenient for others to jump in at this stage for that?

cc/FYI @gus-asf as 9.6 release manager.

Thanks!

@elyograg
Copy link
Contributor

I'm tied up today. If it should happen now, someone else can look into it.

@cpoerschke cpoerschke self-assigned this Apr 12, 2024
@cpoerschke cpoerschke changed the title SOLR-16466 - Admin UI - Make it optional to sort list of commandline … SOLR-16466: Admin UI - Make it optional to sort list of commandline args Apr 12, 2024
@cpoerschke cpoerschke merged commit 7813f0e into apache:main Apr 12, 2024
2 of 3 checks passed
asfgit pushed a commit that referenced this pull request Apr 12, 2024
@cpoerschke cpoerschke removed their assignment Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants