Added comment

apache · Nov 27, 2024 · aef2f0b · aef2f0b
1 parent 3c7d9a4
commit aef2f0b
Show file tree

Hide file tree

Showing 3 changed files with 3,832 additions and 3,839 deletions.
diff --git a/solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java b/solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java
@@ -517,6 +517,8 @@ public void delete(String path) {
         // invoke delete command on all nodes asynchronously
         solrClient.requestWithBaseUrl(baseUrl, client -> client.requestAsync(solrRequest));
       } catch (SolrServerException | IOException e) {
+        // Note: This catch block will not handle failures from the asynchronous request,
+        // as requestAsync returns immediately and does not propagate remote exceptions.
         throw new SolrException(
             SolrException.ErrorCode.SERVER_ERROR,
             "Failed to delete " + path + " on node " + node,

diff --git a/.../cross-dc/src/java/org/apache/solr/crossdc/update/processor/MirroringUpdateProcessor.java b/.../cross-dc/src/java/org/apache/solr/crossdc/update/processor/MirroringUpdateProcessor.java
@@ -223,9 +223,8 @@ public void processDelete(final DeleteUpdateCommand cmd) throws IOException {
         boolean done = false;
         while (!done) {
           q.set(CursorMarkParams.CURSOR_MARK_PARAM, cursorMark);
-          var baseUrl = cmd.getReq().getCore().getCoreContainer().getZkController().getBaseUrl();
           var client = cmd.getReq().getCoreContainer().getDefaultHttpSolrClient();
-          QueryResponse rsp = client.requestWithBaseUrl(baseUrl, c -> c.query(collection, q));
+          QueryResponse rsp = client.query(collection, q);
           String nextCursorMark = rsp.getNextCursorMark();
 
           if (log.isDebugEnabled()) {