remove silly duplicate method

apache · Dec 18, 2024 · 45b9e10 · 45b9e10
1 parent 99282aa
commit 45b9e10
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java b/solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
@@ -374,17 +374,13 @@ PublicKey fetchPublicKeyFromRemote(String nodename) {
     }
   }
 
-  @Override
-  public void setup(Http2SolrClient.Builder httpClientBuilder, Http2SolrClient client) {
-    setup(client, httpClientBuilder);
-  }
-
   @Override
   public void setup(Http2SolrClient client) {
-    setup(client, null);
+    setup(null, client);
   }
 
-  private void setup(Http2SolrClient client, Http2SolrClient.Builder builder) {
+  @Override
+  public void setup(Http2SolrClient.Builder httpClientBuilder, Http2SolrClient client) {
     final HttpListenerFactory.RequestResponseListener listener =
         new HttpListenerFactory.RequestResponseListener() {
           private static final String CACHED_REQUEST_USER_KEY = "cachedRequestUser";
@@ -443,8 +439,8 @@ private Optional<String> getUserFromJettyRequest(Request request) {
     if (client != null) {
       client.addListenerFactory(() -> listener);
     }
-    if (builder != null) {
-      builder.addListenerFactory(() -> listener);
+    if (httpClientBuilder != null) {
+      httpClientBuilder.addListenerFactory(() -> listener);
     }
   }