[ISSUE #9156] Refactor AclUtils#getAclRPCHook #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9157 +/- ##
=============================================
- Coverage 48.11% 48.03% -0.09%
+ Complexity 12091 12072 -19
=============================================
Files 1321 1321
Lines 93024 93024
Branches 11926 11926
=============================================
- Hits 44755 44680 -75
- Misses 42754 42816 +62
- Partials 5515 5528 +13 ☔ View full report in Codecov by Sentry. |
qianye1001
reviewed
Jan 24, 2025
| @@ -47,7 +54,7 @@ public void testGetAddresses() { | |||
| addressList.add("1.1.1.2"); | |||
| addressList.add("1.1.1.3"); | |||
| addressList.add("1.1.1.4"); | |||
| Assert.assertEquals(newAddressList, addressList); | |||
| assertEquals(newAddressList, addressList); | |||
There was a problem hiding this comment.
Are there any benefits to this modification?
There was a problem hiding this comment.
Use static import to reduce redundant code.
There was a problem hiding this comment.
They are both one line of code. Changing it will lose the git blame.
There was a problem hiding this comment.
Okay, I will return to them.
There was a problem hiding this comment.
It has been adjusted. Please review it again. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9156, use fastjson2 to replace fastjson1.