Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9105] Fix the issue of duplicate consumption in LMQ #9101

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Jan 3, 2025

Which Issue(s) This PR Fixes

Fixes #9105

Brief Description

Fix the issue of duplicate consumption in LMQ

How Did You Test This Change?

@RongtongJin RongtongJin marked this pull request as draft January 4, 2025 02:15
@RongtongJin RongtongJin changed the title Fix the issue of duplicate consumption in LMQ [ISSUE #9105] Fix the issue of duplicate consumption in LMQ Jan 4, 2025
@RongtongJin RongtongJin marked this pull request as ready for review January 4, 2025 12:23
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.94%. Comparing base (f32fe78) to head (46cff37).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...etmq/broker/longpolling/PopLongPollingService.java 25.00% 6 Missing ⚠️
...cketmq/broker/processor/PopBufferMergeService.java 0.00% 3 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9101      +/-   ##
=============================================
- Coverage      48.13%   47.94%   -0.20%     
+ Complexity     12083    12039      -44     
=============================================
  Files           1320     1320              
  Lines          92782    92825      +43     
  Branches       11897    11897              
=============================================
- Hits           44665    44503     -162     
- Misses         42625    42808     +183     
- Partials        5492     5514      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DongyuanPan DongyuanPan merged commit 9ce8345 into apache:develop Jan 6, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Messages are duplicated when using LMQ for pop consumption
4 participants