[ISSUE #9025] [RIP-73] Fix reset offset not effective in Pop Consumption #9087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9087 +/- ##
=============================================
+ Coverage 47.97% 48.00% +0.02%
- Complexity 12045 12050 +5
=============================================
Files 1320 1320
Lines 92779 92782 +3
Branches 11896 11897 +1
=============================================
+ Hits 44511 44537 +26
+ Misses 42756 42741 -15
+ Partials 5512 5504 -8 ☔ View full report in Codecov by Sentry. |
lollipopjin
reviewed
Dec 30, 2024
| if (brokerController.getBrokerConfig().isPopConsumerKVServiceEnable()) { | ||
| brokerController.getPopConsumerService().clearCache(group, topic, queueId); | ||
| brokerController.getPopConsumerService().clearCache(group, topic, entry.getKey()); | ||
| brokerController.getConsumerOffsetManager().commitPullOffset( |
There was a problem hiding this comment.
Notice: here if we use the same consumer group to do pull and pop at the same time, they both commit the pull offset, May be pop requests may miss some messages here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9025
Brief Description
How Did You Test This Change?