Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8460] Set default broker name when revive found ack without broker name field #8981

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Nov 25, 2024

Set default broker name when revive found ack without broker name field

POP CK 新旧格式兼容,为了尽可能的减少消费重复,当没有 brokerName 在 ack 信息里的时候自动补全

Which Issue(s) This PR Fixes

Fixes #8460

Brief Description

How Did You Test This Change?

Copy link
Contributor

@GenerousMan GenerousMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.64%. Comparing base (a8779c0) to head (c788856).

Files with missing lines Patch % Lines
...he/rocketmq/broker/processor/PopReviveService.java 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8981      +/-   ##
=============================================
- Coverage      47.70%   47.64%   -0.07%     
+ Complexity     11782    11761      -21     
=============================================
  Files           1304     1304              
  Lines          91188    91192       +4     
  Branches       11713    11715       +2     
=============================================
- Hits           43502    43446      -56     
- Misses         42315    42366      +51     
- Partials        5371     5380       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lollipopjin lollipopjin merged commit b638d4c into apache:develop Nov 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Improve the pop revive process when reading biz messages from a remote broker
5 participants