Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8976] Modify file segment construct method #8977

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #8976

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.64%. Comparing base (a8779c0) to head (6e25f6c).

Files with missing lines Patch % Lines
...ocketmq/tieredstore/provider/PosixFileSegment.java 80.95% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8977      +/-   ##
=============================================
+ Coverage      47.61%   47.64%   +0.03%     
- Complexity     11758    11759       +1     
=============================================
  Files           1304     1304              
  Lines          91188    91193       +5     
  Branches       11713    11713              
=============================================
+ Hits           43418    43449      +31     
+ Misses         42391    42360      -31     
- Partials        5379     5384       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit fc22830 into apache:develop Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Modify file segment construct method
5 participants