Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8961] Automatic recognition of address scheme in Topic Route by host #8962

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Automatic recognition of address scheme in Topic Route by host.

Fixes #8961

Brief Description

How Did You Test This Change?

@dingshuangxi888 dingshuangxi888 changed the title [ISSUE #8961]automatic recognition of address scheme in topic route by host. [ISSUE #8961] Automatic recognition of address scheme in Topic Route by host Nov 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.66%. Comparing base (bf2f2a7) to head (0af0944).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...g/apache/rocketmq/common/utils/IPAddressUtils.java 0.00% 2 Missing ⚠️
...proxy/remoting/activity/GetTopicRouteActivity.java 0.00% 1 Missing ⚠️
...ketmq/proxy/service/route/ProxyTopicRouteData.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8962      +/-   ##
=============================================
- Coverage      47.70%   47.66%   -0.05%     
- Complexity     11759    11763       +4     
=============================================
  Files           1303     1304       +1     
  Lines          91043    91163     +120     
  Branches       11676    11702      +26     
=============================================
+ Hits           43434    43452      +18     
- Misses         42249    42333      +84     
- Partials        5360     5378      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit a8779c0 into apache:develop Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Automatic recognition of address scheme in Topic Route by host.
4 participants