Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8929] Proxy adds message body empty check when send in grpc protocol #8930

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8929

Brief Description

How Did You Test This Change?

@qianye1001
Copy link
Contributor Author

need to resolve dependency conflicts

caigy
caigy previously approved these changes Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.64%. Comparing base (66ba456) to head (0bb04af).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...mq/proxy/grpc/v2/producer/SendMessageActivity.java 0.00% 1 Missing and 2 partials ⚠️
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8930      +/-   ##
=============================================
+ Coverage      47.63%   47.64%   +0.01%     
+ Complexity     11756    11749       -7     
=============================================
  Files           1304     1304              
  Lines          91046    91125      +79     
  Branches       11672    11693      +21     
=============================================
+ Hits           43370    43421      +51     
+ Misses         42341    42325      -16     
- Partials        5335     5379      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lizhimins lizhimins changed the title [ISSUE #8929] Proxy adds message body empty check when send in grpc protocol. [ISSUE #8929] Proxy adds message body empty check when send in grpc protocol Nov 21, 2024
@lizhimins lizhimins merged commit 796c95b into apache:develop Nov 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Proxy adds message body empty check when send in grpc protocol.
5 participants