Add validation in broker/namesrv configure updating command. #7584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
Nov 27, 2023
namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
Show resolved
Hide resolved
RongtongJin
reviewed
Nov 27, 2023
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7584 +/- ##
=============================================
+ Coverage 43.17% 43.22% +0.05%
- Complexity 9780 9787 +7
=============================================
Files 1162 1162
Lines 84303 84339 +36
Branches 10949 10952 +3
=============================================
+ Hits 36396 36454 +58
+ Misses 43386 43357 -29
- Partials 4521 4528 +7 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
Nov 27, 2023
RongtongJin
previously approved these changes
Nov 27, 2023
ShannonDing
force-pushed
the
broker_config_update
branch
from
7464fc3 to
252d2d2
Compare
RongtongJin
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation in broker/namesrv configure updating command.